zentol commented on a change in pull request #9638: [FLINK-13883] Deprecate
unused AkkaOptions related to Akka's death watch
URL: https://github.com/apache/flink/pull/9638#discussion_r321673258
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/testutils/ZooKeeperTestUtils.java
##########
@@ -81,10 +81,6 @@ public static Configuration configureZooKeeperHA(
config.setString(CheckpointingOptions.CHECKPOINTS_DIRECTORY,
fsStateHandlePath + "/checkpoints");
config.setString(HighAvailabilityOptions.HA_STORAGE_PATH,
fsStateHandlePath + "/recovery");
- // Akka failure detection and execution retries
- config.setString(AkkaOptions.WATCH_HEARTBEAT_INTERVAL, "1000
ms");
Review comment:
I suppose the idea behind removing them, instead of an update to the new
options, is that since they didn't fail with ineffective options they obviously
don't needed them in the first place? (same question for kafka)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
