tillrohrmann commented on a change in pull request #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend URL: https://github.com/apache/flink/pull/9501#discussion_r321714149
########## File path: flink-state-backends/flink-statebackend-heap-spillable/src/test/java/org/apache/flink/runtime/state/heap/SkipListKeyComparatorTest.java ########## @@ -0,0 +1,240 @@ +/* + * + * * Licensed to the Apache Software Foundation (ASF) under one + * * or more contributor license agreements. See the NOTICE file + * * distributed with this work for additional information + * * regarding copyright ownership. The ASF licenses this file + * * to you under the Apache License, Version 2.0 (the + * * "License"); you may not use this file except in compliance + * * with the License. You may obtain a copy of the License at + * * + * * http://www.apache.org/licenses/LICENSE-2.0 + * * + * * Unless required by applicable law or agreed to in writing, software + * * distributed under the License is distributed on an "AS IS" BASIS, + * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * * See the License for the specific language governing permissions and + * * limitations under the License. + * + */ + +package org.apache.flink.runtime.state.heap; + +import org.apache.flink.api.common.typeutils.TypeSerializer; +import org.apache.flink.api.common.typeutils.TypeSerializerSnapshot; +import org.apache.flink.api.common.typeutils.base.IntSerializer; +import org.apache.flink.api.common.typeutils.base.LongSerializer; +import org.apache.flink.api.common.typeutils.base.TypeSerializerSingleton; +import org.apache.flink.core.memory.DataInputView; +import org.apache.flink.core.memory.DataOutputView; +import org.apache.flink.util.TestLogger; + +import org.junit.Test; + +import java.io.IOException; +import java.nio.ByteBuffer; + +import static org.junit.Assert.assertTrue; + +/** + * Tests for {@link SkipListKeyComparator}. + */ +public class SkipListKeyComparatorTest extends TestLogger { + + @Test + public void testCompareSkipListKeyForPrimitive() { + // The comparison of the serialized forms are identical to that of + // the values only when the numbers to compare are both not negative. + TypeSerializer<Long> keySerializer = LongSerializer.INSTANCE; + TypeSerializer<Integer> namespaceSerializer = IntSerializer.INSTANCE; + + SkipListKeySerializer<Long, Integer> skipListKeySerializer = + new SkipListKeySerializer<>(keySerializer, namespaceSerializer); + + // verify equal namespace and key + verifySkipListKey(skipListKeySerializer, 0L, 0, 0L, 0, 0); + + // verify equal namespace and unequal key + verifySkipListKey(skipListKeySerializer, 0L, 5, 1L, 5, -1); + verifySkipListKey(skipListKeySerializer, 192L, 90, 87L, 90, 1); + + // verify unequal namespace and equal key + verifySkipListKey(skipListKeySerializer, 8374L, 73, 8374L, 1212, -1); + verifySkipListKey(skipListKeySerializer, 839L, 23231, 839L, 2, 1); + + // verify unequal namespace and unequal key + verifySkipListKey(skipListKeySerializer, 1L, 2, 3L, 4, -1); + verifySkipListKey(skipListKeySerializer, 1L, 4, 3L, 2, 1); + verifySkipListKey(skipListKeySerializer, 3L, 2, 1L, 4, -1); + verifySkipListKey(skipListKeySerializer, 3L, 4, 1L, 2, 1); Review comment: I think every section separate by comments deserves its own test method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
