walterddr commented on a change in pull request #8746: [hotfix][FLINK-11120][table]fix the bug of timestampadd handles time URL: https://github.com/apache/flink/pull/8746#discussion_r321954915
########## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala ########## @@ -186,7 +186,12 @@ object ScalarOperatorGens { case (TIME_WITHOUT_TIME_ZONE, INTERVAL_DAY_TIME) => generateOperatorIfNotNull(ctx, new TimeType(), left, right) { - (l, r) => s"$l $op ((int) ($r))" + (l, r) => s"($l $op ((int) ($r))) % ${MILLIS_PER_DAY}" Review comment: looks like similar lines can be added to `ScalarOperator.scala` class in flink-table-planner as well in order to support the test cases. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services