GJL commented on a change in pull request #9637: [FLINK-13884] Set default
delay for restart strategies to 1s
URL: https://github.com/apache/flink/pull/9637#discussion_r322274845
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/RestartStrategyOptions.java
##########
@@ -116,10 +115,9 @@
Description.builder()
.text(
"Time interval for measuring failure
rate if %s has been set to %s. " +
- "It can be specified using
Scala's %s notation: \"1 min\", \"20 s\"",
+ "It can be specified using the
notation: \"1 min\", \"20 s\", \"100 ms\"",
Review comment:
That's a valid point. Though, for the affected durations in this commits it
probably does not make sense to specify these in days, microseconds, or
nanoseconds. I would say that the changes in this commit are out of scope for a
_hotfix_ commit. Strictly speaking the changes in this commit even break
backwards compatibility.
_Edit:_ Now I understand the full extent of the issue that @zhuzhurk raised.
There are many more notations that we do not support anymore (not only units).
Scala's Duration also supported specifications such as _"5 minutes"_, which
`TimeUtils` does not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
