GJL commented on a change in pull request #8912: [FLINK-12709] [runtime] 
Implement new generation restart strategy loader which also respects legacy…
URL: https://github.com/apache/flink/pull/8912#discussion_r323195327
 
 

 ##########
 File path: 
flink-core/src/main/java/org/apache/flink/configuration/RestartBackoffTimeStrategyOptions.java
 ##########
 @@ -25,6 +25,16 @@
  */
 @PublicEvolving
 public class RestartBackoffTimeStrategyOptions {
+
+       /**
+        * Class name of the RestartBackoffTimeStrategy implementation to use.
+        */
+       @PublicEvolving
+       public static final ConfigOption<String> 
RESTART_BACKOFF_TIME_STRATEGY_CLASS_NAME = ConfigOptions
+               .key("restart-backoff-time-strategy.class-name")
 
 Review comment:
   With the introduction of the new scheduler, users will not be able to use 
custom implementations of the `RestartStrategy` interface. Strictly speaking 
this is a breaking change. However, it is not clear to me if there are any 
Flink users at all that require a custom `RestartStrategy`. I think it makes 
sense to start a discussion on the dev mailing list. Until it is clear that 
users require this level of customization, I think we should provide users a 
way to write their own back off time strategy.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to