[ 
https://issues.apache.org/jira/browse/FLINK-14057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928385#comment-16928385
 ] 

Aljoscha Krettek commented on FLINK-14057:
------------------------------------------

It would probably be better to add a separate method for dropping timers 
instead of overloading that functionality on "add timer".

> Add Remove Other Timers to TimerService
> ---------------------------------------
>
>                 Key: FLINK-14057
>                 URL: https://issues.apache.org/jira/browse/FLINK-14057
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Jesse Anderson
>            Priority: Major
>
> The TimerService service has the ability to add timers with 
> registerProcessingTimeTimer. This method can be called many times and have 
> different timer times.
> If you want to add a new timer and delete other timers, you have to keep 
> track of all previous timer times and call deleteProcessingTimeTimer for each 
> time. This method forces you to keep track of all previous (unexpired) timers 
> for a key.
> Instead, I suggest overloading registerProcessingTimeTimer with a second 
> boolean argument that will remove all previous timers and set the new timer.
> Note: although I'm using registerProcessingTimeTimer, this applies to 
> registerEventTimeTimer as well.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to