xuefuz commented on a change in pull request #8859: 
[FLINK-12905][table-planner] Enable querying CatalogViews in legacy planner
URL: https://github.com/apache/flink/pull/8859#discussion_r323991792
 
 

 ##########
 File path: 
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/AbstractCatalogView.java
 ##########
 @@ -42,9 +43,15 @@
        private final TableSchema schema;
        private final Map<String, String> properties;
        private final String comment;
+       private final SqlDialect dialect;
 
 Review comment:
   This needs to be persisted somehow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to