[
https://issues.apache.org/jira/browse/FLINK-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945312#comment-14945312
]
ASF GitHub Bot commented on FLINK-2785:
---------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1205#issuecomment-145921072
Hi, you might have noticed, I got a bit confused about the `vertexValue`
parameter and how it affects the graph creation. I made a proposal inline to
rename that parameter and making it mandatory. Let me know what you think. The
documentation should discuss the `vertexValue` in more detail.
Otherwise the PR looks good.
> Implement Graph's fromCsvReader in Gelly-Scala
> ----------------------------------------------
>
> Key: FLINK-2785
> URL: https://issues.apache.org/jira/browse/FLINK-2785
> Project: Flink
> Issue Type: Sub-task
> Components: Gelly
> Reporter: Vasia Kalavri
> Assignee: Vasia Kalavri
> Priority: Minor
>
> Graphs's {{fromCsvReader}} method is currently missing from the Gelly Scala
> API. It cannot be implemented as a simple wrapper over the Java method,
> because the Java method returns a {{GraphCsvReader}}, which in return creates
> a Graph after specifying types with appropriate methods. The Scala version of
> the method can be more nicely implemented using the {{ScalaCsvInputFormat}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
