TisonKun commented on a change in pull request #9686: [FLINK-14069] [core]
Enable TimeUtils for all time units labels supported by scala Duration
URL: https://github.com/apache/flink/pull/9686#discussion_r325037923
##########
File path: flink-core/src/test/java/org/apache/flink/util/TimeUtilsTest.java
##########
@@ -123,9 +154,4 @@ public void testParseDurationInvalid() {
public void testParseDurationNumberOverflow() {
TimeUtils.parseDuration("100000000000000000000000000000000 ms");
}
-
- @Test(expected = IllegalArgumentException.class)
- public void testParseDurationNumberTimeUnitOverflow() {
Review comment:
With your patch we still possibly throw an `IllegalArgumentException` if the
number overflow. Why do you remove this test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
