zhuzhurk commented on a change in pull request #9686: [FLINK-14069] [core]
Enable TimeUtils for all time units labels supported by scala Duration
URL: https://github.com/apache/flink/pull/9686#discussion_r325061889
##########
File path: flink-core/src/test/java/org/apache/flink/util/TimeUtilsTest.java
##########
@@ -123,9 +154,4 @@ public void testParseDurationInvalid() {
public void testParseDurationNumberOverflow() {
TimeUtils.parseDuration("100000000000000000000000000000000 ms");
}
-
- @Test(expected = IllegalArgumentException.class)
- public void testParseDurationNumberTimeUnitOverflow() {
Review comment:
This test was for some removed logics in TimeUtils.
Currently this case can cause `ArithmeticException` thrown from
`java.time.Duration`.
But I think we do not need it, just like we do not need to add tests for
formats validation, which should be tested by `java.time.Duration` itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
