TisonKun opened a new pull request #9700: [FLINK-14050][yarn] Refactor YarnClusterDescriptor inheritance URL: https://github.com/apache/flink/pull/9700 ## What is the purpose of the change Currently, the inheritance looks like AbstractYarnClusterDescriptor -> YarnClusterDescriptor -> TestingYarnClusterDescriptor -> NonDeployingYarnClusterDescriptor -> -> NonDeployingDetachedYarnClusterDescriptor With an investigation, I find 1. AbstractYarnClusterDescriptor is introduced for migration purpose and no need any more. 2. TestingYarnClusterDescriptor is redundant and can be replaced directly with YarnClusterDescriptor. 3. Some methods like #createYarnClusterClient have parameters that never used, which are for historical reasons. Thus, I propose we refactor YarnClusterDescriptor inheritance YarnClusterDescriptor -> NonDeployingYarnClusterDescriptor -> -> NonDeployingDetachedYarnClusterDescriptor and also methods remove unused parameters. ## Brief change log 1. Refactor YarnClusterDescriptor inheritance 2. Narrow visibility from protected to private or package-private since there is no need to be inherited ant more. 3. Remove unused parameter from #createYarnClusterClient ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes, we refactor YarnClusterDescriptor inheritance which takes care of Yarn deployment) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) cc @tillrohrmann @aljoscha @kl0u
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
