zhijiangW commented on a change in pull request #9483: [FLINK-13767][task]
Refactor StreamInputProcessor#processInput based on InputStatus
URL: https://github.com/apache/flink/pull/9483#discussion_r325177476
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTwoInputProcessor.java
##########
@@ -184,10 +184,6 @@ public boolean processInput() throws Exception {
}
checkFinished(status, lastReadInputIndex);
- if (status != InputStatus.MORE_AVAILABLE) {
Review comment:
Yes, I refactored this part in a separate hotfix commit for integrating the
logics of `inputSelectionHandler#setAvailableIndex` and `setUnavailableIndex`
together before `emitNext` call. In the past these two logics are scattered
before and after `emitNext` separately.
I do not think it would impact the performance, and at-least in my benchmark
results it has not caused. I am curious that are there any purpose to update
the selection immediately before?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
