gaoyunhaii commented on a change in pull request #9679: [hotfix] Fix the
comments related to side output.
URL: https://github.com/apache/flink/pull/9679#discussion_r325982849
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
##########
@@ -549,7 +549,7 @@ public void collect(StreamRecord<T> record) {
@Override
public <X> void collect(OutputTag<X> outputTag, StreamRecord<X>
record) {
if (this.outputTag == null ||
!this.outputTag.equals(outputTag)) {
- // we are only responsible for emitting to the
side-output specified by our
+ // we are not responsible for emitting to the
side-output specified by this
Review comment:
I think if the output tag is null, this output should be responsible for
emitting to the main output instead of one side output.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
