xuyang1706 commented on a change in pull request #9184: [FLINK-13339][ml] Add an implementation of pipeline's api URL: https://github.com/apache/flink/pull/9184#discussion_r326136401
########## File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/pipeline/PipelineStage.java ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.flink.ml.pipeline; + +import org.apache.flink.ml.api.misc.param.Params; +import org.apache.flink.ml.api.misc.param.WithParams; + +/** + * Abstract class for a stage in a pipeline, either an [[Estimator]] or a [[Transformer]]. + * + * <p>Each pipeline stage is with parameters, and requires a public empty constructor for + * restoration in Pipeline. It implement the {@link org.apache.flink.ml.api.core.PipelineStage} + * and hold a {@link Params} as its member, thus the subclasses could do not care about + * {@link WithParams#getParams()} + * + * @param <S> The class type of the {@link PipelineStage} implementation itself, used by {@link + * org.apache.flink.ml.api.misc.param.WithParams} and Cloneable. + */ +public abstract class PipelineStage<S extends PipelineStage <S>> Review comment: > Same here, `PipelineStageBase`? This class does not implement the `org.apache.flink.ml.api.core.PipelineStage`, is this intended? > I am not sure this class is a must. I think each type of pipeline stage individually can set its own base class. see: https://stackoverflow.com/a/3599379/11332462 It has been renamed and PipelineStage is the standard concept in pipeline and if it implements the `WithParams` , the subclasses could do not care about `WithParams` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
