yxu-valleytider commented on issue #9581: [FLINK-13864][streaming]: Modify the StreamingFileSink Builder interface to allow for easier subclassing of StreamingFileSink URL: https://github.com/apache/flink/pull/9581#issuecomment-533203569 @aljoscha The metrics collection needs be done inside `notifyCheckpointComplete()` and `snapshotState()`. In addition, we may add customized logic into these two function as well. Some of the logic are specific to our use cases, and probably better to stay inside our own customized `StreamingFileSink`. I'm following the cited articles' suggestion in order to make the builder pattern extensible to the subclasses.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
