lirui-apache commented on a change in pull request #9721: [FLINK-14129][hive]
HiveTableSource should implement ProjectableTable…
URL: https://github.com/apache/flink/pull/9721#discussion_r326465346
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java
##########
@@ -66,6 +68,7 @@
private Map<Map<String, String>, HiveTablePartition>
partitionSpec2HiveTablePartition = new HashMap<>();
private boolean initAllPartitions;
private boolean partitionPruned;
+ private int[] projectedFields;
public HiveTableSource(JobConf jobConf, ObjectPath tablePath,
CatalogTable catalogTable) {
this.jobConf = Preconditions.checkNotNull(jobConf);
Review comment:
I'd like to keep `projectedFields ` as null to indicate no projection has
been pushed down to this table source. So that `explainSource()` doesn't have
to display all the column indices if no projection is ever applied. What do you
think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
