zhuzhurk commented on a change in pull request #9723: [FLINK-14114] [client]
Shift down ClusterClient#timeout to RestClusterClient
URL: https://github.com/apache/flink/pull/9723#discussion_r326478660
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
##########
@@ -125,13 +126,18 @@
import java.util.function.Supplier;
import java.util.stream.Collectors;
+import scala.concurrent.duration.FiniteDuration;
+
/**
* A {@link ClusterClient} implementation that communicates via HTTP REST
requests.
*/
public class RestClusterClient<T> extends ClusterClient<T> implements
NewClusterClient {
private final RestClusterClientConfiguration
restClusterClientConfiguration;
+ /** Timeout for futures. */
+ private final FiniteDuration timeout;
Review comment:
@TisonKun Maybe it's better to focus on the shifting work in this PR.
So I'd like keep the type FiniteDuration here and change it to
java.time.Duration in the PR of FLINK-14070.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
