lirui-apache commented on issue #9721: [FLINK-14129][hive] HiveTableSource should implement ProjectableTable… URL: https://github.com/apache/flink/pull/9721#issuecomment-533466244 PR updated to address comments. @bowenli86 I'm not pre-computing partition names/values. As @JingsongLi suggested, we can reuse the row instance in `nextRecord`, and therefore we only need to compute the partition values once. @xuefuz I've created https://issues.apache.org/jira/browse/FLINK-14148 to track the TODO.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
