azagrebin commented on a change in pull request #8479: [FLINK-11193][State 
Backends]Use user passed configuration overriding default configuration loading 
from file
URL: https://github.com/apache/flink/pull/8479#discussion_r323107972
 
 

 ##########
 File path: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
 ##########
 @@ -507,7 +507,7 @@ public CheckpointStorage createCheckpointStorage(JobID 
jobId) throws IOException
                        keyGroupRange,
                        executionConfig,
                        localRecoveryConfig,
-                       priorityQueueStateType,
+                       getPriorityQueueStateType(priorityQueueStateType),
 
 Review comment:
   `priorityQueueStateType` is a class field, do we actually need to pass it to 
`getPriorityQueueStateType ` if it is already available there?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to