AHeise commented on a change in pull request #7713: [FLINK-10995][runtime] Copy
intermediate serialization results only once for broadcast mode
URL: https://github.com/apache/flink/pull/7713#discussion_r327062031
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java
##########
@@ -54,23 +54,17 @@
*
* @param <T> the type of the record that can be emitted with this record
writer
*/
-public class RecordWriter<T extends IOReadableWritable> {
+public abstract class RecordWriter<T extends IOReadableWritable> {
private static final Logger LOG =
LoggerFactory.getLogger(RecordWriter.class);
- private final ResultPartitionWriter targetPartition;
+ protected final ResultPartitionWriter targetPartition;
- private final ChannelSelector<T> channelSelector;
+ protected final int numberOfChannels;
Review comment:
any reason to switch the order of fields here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
