[ 
https://issues.apache.org/jira/browse/FLINK-14075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16935802#comment-16935802
 ] 

Flavio Pompermaier commented on FLINK-14075:
--------------------------------------------

If I look at 
[https://github.com/apache/flink/blob/master/flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormatTest.java]
 nothing has changed..am I missing something?

> Remove unnecessary resource close in JDBCOutputFormatTest.java
> --------------------------------------------------------------
>
>                 Key: FLINK-14075
>                 URL: https://issues.apache.org/jira/browse/FLINK-14075
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / JDBC
>            Reporter: Canbin Zheng
>            Priority: Minor
>             Fix For: 1.10.0
>
>
>  
> {code:java}
> public void clearOutputTable() throws Exception {
>    Class.forName(DRIVER_CLASS);
>    try (
>       Connection conn = DriverManager.getConnection(DB_URL);
>       Statement stat = conn.createStatement()) {
>       stat.execute("DELETE FROM " + OUTPUT_TABLE);
>       stat.close();
>       conn.close();
>    }
> }{code}
> Unnecessary close of stat and conn can be removed.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to