tillrohrmann commented on a change in pull request #9719: 
[FLINK-14010][coordination] Shutdown cluster if ResourceManager terminated 
unexpectedly
URL: https://github.com/apache/flink/pull/9719#discussion_r327104969
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/component/DispatcherResourceManagerComponent.java
 ##########
 @@ -106,6 +107,16 @@ private void registerShutDownFuture() {
                                                
shutDownFuture.complete(ApplicationStatus.SUCCEEDED);
                                        }
                                });
+
+               resourceManager
+                       .getTerminationFuture()
+                       .whenComplete(
+                               (aVoid, throwable) -> {
+                                       if (isRunning.get()) {
+                                               
shutDownFuture.completeExceptionally(
+                                                       new 
FlinkException("ResourceManager got closed when 
DispatcherResourceManagerComponent is running"));
 
 Review comment:
   ```suggestion
                                                        new 
FlinkException("ResourceManager was unexpectedly terminated while 
DispatcherResourceManagerComponent was running. This indicates either a failure 
of the ResourceManager or that it was asked to shut down by the external 
resource management system."));
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to