KurtYoung commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0 URL: https://github.com/apache/flink/pull/9712#discussion_r327449304
########## File path: flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl ########## @@ -644,26 +532,35 @@ void FieldNameTypeCommaList( } /** -* Parse Row type, we support both Row(name1 type1, name2 type2) and Row<name1 type1, name2 type2>. -* Every item type can have suffix of `NULL` or `NOT NULL` to indicate if this type is nullable. -* i.e. Row(f0 int not null, f1 varchar null). +* Parse Row type, we support both Row(name1 type1, name2 type2) +* and Row<name1 type1, name2 type2>. +* Every item type can have a suffix of `NULL` or `NOT NULL` to indicate if this type is nullable. +* i.e. Row(f0 int not null, f1 varchar null). Default is nullable. */ -SqlIdentifier SqlRowType() : +SqlTypeNameSpec ExtendedSqlRowTypeName() : Review comment: why we have to provide this if calcite already support ROW ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
