dianfu commented on issue #9748: [FLINK-14016][python][flink-table-planner] Introduce FlinkLogicalPythonScalarFunctionExec and DataStreamPythonScalarFunctionExec for Python function execution URL: https://github.com/apache/flink/pull/9748#issuecomment-534842612 @sunjincheng121 I have updated the PR and have addressed your comments with just one exception. Regarding to the filter part as I found that it's a big optimization and deserve a separate rule. The functionality of PythonScalarFunctionSplitRule which is introduced in this PR focuses on separating the Python UDFs from the Java UDFs mixed in a Calc node. For the filter optimization, we need introduce a new rule which is responsible for splitting a Calc node into two Calc nodes if it contains condition and the projection contains Python UDFs. The generated bottom Calc contains the filter part and the top Calc contains the projection part. Does it make sense to you? If yes, I will create a follow up ticket for this optimization.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
