KurtYoung commented on a change in pull request #9712: [FLINK-13656] [sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 1.21.0 URL: https://github.com/apache/flink/pull/9712#discussion_r328065038
########## File path: flink-table/flink-sql-parser/src/main/codegen/data/Parser.tdd ########## @@ -394,23 +389,13 @@ ] # List of methods for parsing ddl supported data types. - # Return type of method implementation should be "SqlIdentifier". - # Example: SqlParseTimeStampZ(). - flinkDataTypeParserMethods: [ - "SqlArrayType()", - "SqlMultisetType()", - "SqlMapType()", - "SqlRowType()", - "SqlStringType()", - "SqlBytesType()", - "SqlTimestampType()", - "SqlTimeType()" - ] - - # List of methods for parsing custom data types. - # Return type of method implementation should be "SqlIdentifier". + # Return type of method implementation should be "SqlTypeNameSpec". # Example: SqlParseTimeStampZ(). dataTypeParserMethods: [ + "ExtendedSqlBasicTypeName()", + "CustomizedCollectionsTypeName()", Review comment: change this name to `ExtendedSqlCollectionsTypeName` to be more align with other methods? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
