[
https://issues.apache.org/jira/browse/FLINK-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937657#comment-16937657
]
Jingsong Lee edited comment on FLINK-13740 at 9/25/19 12:20 PM:
----------------------------------------------------------------
Hi [~hequn8128] and [~jark] , In my opinion, TypeSerializer copy is too heavy
for element copy.
I suggest we can remove BinaryGeneric.copy and do these logic in
BinaryGenericSerializer.copy (Use serializer in BinaryGenericSerializer instead
of serializer in BinaryGeneric), in this way, we can use thread local
serializer to do thread local things. What do you think?
was (Author: lzljs3620320):
Hi [~hequn8128] and [~jark] , In my opinion, TypeSerializer copy is too heavy
for element copy.
I suggest we can remove BinaryGeneric.copy and do these logic in
BinaryGenericSerializer.copy (Use BinaryGenericSerializer instead of serializer
in BinaryGeneric), in this way, we can use thread local serializer to do thread
local things. What do you think?
> TableAggregateITCase.testNonkeyedFlatAggregate failed on Travis
> ---------------------------------------------------------------
>
> Key: FLINK-13740
> URL: https://issues.apache.org/jira/browse/FLINK-13740
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
> Affects Versions: 1.9.0, 1.10.0
> Reporter: Till Rohrmann
> Priority: Critical
> Labels: test-stability
> Fix For: 1.10.0, 1.9.1
>
>
> The {{TableAggregateITCase.testNonkeyedFlatAggregate}} failed on Travis with
> {code}
> org.apache.flink.runtime.client.JobExecutionException: Job execution failed.
> at
> org.apache.flink.table.planner.runtime.stream.table.TableAggregateITCase.testNonkeyedFlatAggregate(TableAggregateITCase.scala:93)
> Caused by: java.lang.Exception: Artificial Failure
> {code}
> https://api.travis-ci.com/v3/job/225551182/log.txt
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
