AHeise commented on a change in pull request #9717: [FLINK-14044] [runtime] 
Reducing synchronization in AsyncWaitOperator
URL: https://github.com/apache/flink/pull/9717#discussion_r328135185
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/async/AsyncFunction.java
 ##########
 @@ -89,6 +89,7 @@
        /**
         * {@link AsyncFunction#asyncInvoke} timeout occurred.
         * By default, the result future is exceptionally completed with a 
timeout exception.
+        * Note that timeout and asyncInvoke might be invoked at the same time.
 
 Review comment:
   I also thought about it, but the question is on how you define invoke:
   if I have an asyncInvoke to an external system that takes a long time, then 
the timeout will be called when asyncInvoke is still in execution. so both are 
active at the same time, but ofc if you define invocation as the act of trigger 
the call, then it's not possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to