[
https://issues.apache.org/jira/browse/FLINK-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937893#comment-16937893
]
tison commented on FLINK-14114:
-------------------------------
With another investigation I think this timeout, whose value is the same as
akka timeout, is a default value without good reason. During the effort of
FLIP-74 we possibly replace all synchronous methods of ClusterClient with
their asynchronous version. If so, this timeout can be removed, where users of
these method should make the decision about the exact timeout at place.
> Shift down ClusterClient#timeout to RestClusterClient
> -----------------------------------------------------
>
> Key: FLINK-14114
> URL: https://issues.apache.org/jira/browse/FLINK-14114
> Project: Flink
> Issue Type: Sub-task
> Components: Client / Job Submission
> Reporter: tison
> Assignee: Zhu Zhu
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{ClusterClient#timeout}} is only used in {{RestClusterClient}}, even without
> this prerequisite we can always shift down {{timeout}} field to subclasses of
> {{ClusterClient}}. It is towards an interface-ized {{ClusterClient}}. By side
> effect, we could reduce the dependency to parsing duration with Scala
> Duration on the fly.
> CC [~till.rohrmann] [~zhuzh]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
