danny0405 commented on a change in pull request #9712: [FLINK-13656] 
[sql-parser][table-planner][table-planner-blink] Bump Calcite dependency to 
1.21.0
URL: https://github.com/apache/flink/pull/9712#discussion_r328413261
 
 

 ##########
 File path: 
flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl
 ##########
 @@ -81,6 +66,33 @@ void TableColumn2(List<SqlNode> list) :
     }
 }
 
+/**
+* Different with #DataType, we support a [ NULL | NOT NULL ] suffix syntax for 
both the
 
 Review comment:
   No, for `#DataType`, i mean the parser block name, maybe `#DataType()` is 
better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to