[ 
https://issues.apache.org/jira/browse/FLINK-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938238#comment-16938238
 ] 

Jingsong Lee commented on FLINK-13740:
--------------------------------------

Let me clear the solutions:

1.Let BinaryGeneric not extends LazyBinaryFormat and all supported method of 
BinaryGeneric should pass javaObjectSer to it.

2.Add sync to materialize(there are many invoking to it), and remove copy in 
BinaryGeneric.

For performance, #1 is better.

For easy fix and LazyBinaryFormat definition, #2 is better.

> TableAggregateITCase.testNonkeyedFlatAggregate failed on Travis
> ---------------------------------------------------------------
>
>                 Key: FLINK-13740
>                 URL: https://issues.apache.org/jira/browse/FLINK-13740
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / Planner
>    Affects Versions: 1.9.0, 1.10.0
>            Reporter: Till Rohrmann
>            Priority: Critical
>              Labels: test-stability
>             Fix For: 1.10.0, 1.9.1
>
>
> The {{TableAggregateITCase.testNonkeyedFlatAggregate}} failed on Travis with 
> {code}
> org.apache.flink.runtime.client.JobExecutionException: Job execution failed.
>       at 
> org.apache.flink.table.planner.runtime.stream.table.TableAggregateITCase.testNonkeyedFlatAggregate(TableAggregateITCase.scala:93)
> Caused by: java.lang.Exception: Artificial Failure
> {code}
> https://api.travis-ci.com/v3/job/225551182/log.txt



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to