zhuzhurk opened a new pull request #9778: [FLINK-14206][runtime] Let fullRestart metric count both full restarts and fine grained restarts URL: https://github.com/apache/flink/pull/9778 ## What is the purpose of the change With fine grained recovery introduced in 1.9.0, the fullRestart metric only counts how many times the entire graph has been restarted, not including the number of fine grained failure restarts. As many users leverage this metric for failure detecting monitoring and alerting, this PR is to make it also count fine grained restarts. ## Brief change log - Add a counter numberOfRestartsCounter in ExecutionGraph to count all restarts. The counter is not to be registered to metric groups. - Let NumberOfFullRestartsGauge query the value of the counter, instead of ExecutionGraph#globalModVersion - increment numberOfRestartCounter in ExecutionGraph#incrementGlobalModVersion() - increment numberOfRestartCounter in AdaptedRestartPipelinedRegionStrategyNG#restartTasks ## Verifying this change - *Added tests for the new counter* - *This change to NumberOfFullRestartsGauge is already covered by existing tests.* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
