a-siuniaev commented on issue #9767: [FLINK-14120][API/Datastream] Fix 
testImmediateShutdown
URL: https://github.com/apache/flink/pull/9767#issuecomment-535880099
 
 
   Totally agree. 
   But I think another thing we're testing here is that 
`timer.registerTimer(...)` and `timer.scheduleAtFixedRate(...)` are resulting 
in an Exception immediately after calling `timer.serviceShutdown() `(and not 
waiting for the underlying task to respond to interruption). 
   So, I suppose we should add assertion which wait for a `CompletableFuture` 
to finish with `InterruptedException` in the very end of the test (to verify 
that underlying task was eventually interrupted). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to