Github user sachingoel0101 commented on the pull request:

    https://github.com/apache/flink/pull/1233#issuecomment-146433225
  
    @rmetzger , I looked at your changes to enable the dashboard on yarn. Looks 
good. :)
    
    A few comments to make sure this PR can directly start working after yours:
    I would like to rename the yarn log files to `jobmanager.log`, 
`jobmanager.out` and `jobmanager.err`. Can you do this with your commit?
    Further, the web runtime resources and log file paths are entirely 
different things. Right now, in normal mode, I can assume that the log files 
are present under the directory `flink.base.dir.key/log`. However, that won't 
be the case in yarn. What would be the best way to pass the log directory path 
to Web runtime? Should it be given as an argument or as an environment 
variable? I'm more inclined towards an ev.
    
    After you address my comments, I will rebase this on top of your PR and 
check if everything works. :)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to