hequn8128 commented on a change in pull request #9766: [FLINK-14018][python] 
Add Python building blocks to make sure the basic functionality of Python 
ScalarFunction could work
URL: https://github.com/apache/flink/pull/9766#discussion_r329295245
 
 

 ##########
 File path: flink-python/pyflink/table/table_environment.py
 ##########
 @@ -542,6 +542,36 @@ def register_java_function(self, name, 
function_class_name):
             .loadClass(function_class_name).newInstance()
         self._j_tenv.registerFunction(name, java_function)
 
+    def register_function(self, name, function):
 
 Review comment:
   Previously, in `test_environment_completeness.py`, we ignore this method 
when check the Api alignment between python and Java. We should also check this 
method from now on. 
   
   We can just remove the `registerFunction` in the 
`test_environment_completeness.py`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to