[
https://issues.apache.org/jira/browse/FLINK-2779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14948328#comment-14948328
]
ASF GitHub Bot commented on FLINK-2779:
---------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1208#issuecomment-146464070
Last part of review:
Connectors
- (with the exception of Twitter where only a source is provided and
Elasticsearch where only a sink is provided) -> The following list only shows
sink for HDFS. I'd just remove the exception sentence.
Kafka Source:
- This section describes the FlinkKafkaConsumer082 and not the KafkaSource
Kafka Sink:
- This sentence is confusing, IMO: "Also the serializer configuration
should be left default, the serialization should be set via
SerializationSchema."
Elasticsearch:
- "Sink" is sometimes capitalized, sometimes not.
- Not how -> Note how
Hadoop FileSystem
- Hadoop FileSystem -> Hadoop File System
- "Sink" is sometimes capitalized, sometimes not.
Twitter Streaming API
- Remember to keep these pieces of information a secret -> Remember to keep
these pieces of information secret (remove "a")
- numberOfTweets determine how many tweet the source emits. ->
numberOfTweets determineS how many tweet the source emits.
> Update documentation to reflect new Stream/Window API
> -----------------------------------------------------
>
> Key: FLINK-2779
> URL: https://issues.apache.org/jira/browse/FLINK-2779
> Project: Flink
> Issue Type: Sub-task
> Components: Streaming
> Reporter: Aljoscha Krettek
> Assignee: Kostas Tzoumas
> Fix For: 0.10
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
