[
https://issues.apache.org/jira/browse/FLINK-14050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kostas Kloudas closed FLINK-14050.
----------------------------------
Resolution: Fixed
Merged to master with 542751ce6af4ab6b507a7c808f975182ce94d560
> Refactor YarnClusterDescriptor inheritance
> ------------------------------------------
>
> Key: FLINK-14050
> URL: https://issues.apache.org/jira/browse/FLINK-14050
> Project: Flink
> Issue Type: Sub-task
> Components: Client / Job Submission, Command Line Client
> Affects Versions: 1.10.0
> Reporter: Zili Chen
> Assignee: Zili Chen
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, the inheritance looks like
> AbstractYarnClusterDescriptor
> -> YarnClusterDescriptor
> -> TestingYarnClusterDescriptor
> -> NonDeployingYarnClusterDescriptor
> -> -> NonDeployingDetachedYarnClusterDescriptor
> With an investigation, I find
> 1. AbstractYarnClusterDescriptor is introduced for migration purpose and no
> need any more.
> 2. TestingYarnClusterDescriptor is redundant and can be replaced directly
> with YarnClusterDescriptor.
> 3. NonDeployingDetachedYarnClusterDescriptor is no need. We can just use
> NonDeployingYarnClusterDescriptor.
> 4. Some methods like #createYarnClusterClient have parameters that never
> used, which are for historical reasons.
> Thus, I propose we refactor YarnClusterDescriptor inheritance
> YarnClusterDescriptor
> -> NonDeployingYarnClusterDescriptor
> and also methods remove unused parameters.
> CC [~kkl0u] [~aljoscha] [~till.rohrmann]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
