TisonKun commented on a change in pull request #9810: [FLINK-14284] Add shut
down future to Dispatcher
URL: https://github.com/apache/flink/pull/9810#discussion_r329857622
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -603,7 +616,7 @@ private JobManagerRunner
startJobManagerRunner(JobManagerRunner jobManagerRunner
@Override
public CompletableFuture<Acknowledge> shutDownCluster() {
- closeAsync();
+ shutDownFuture.complete(ApplicationStatus.SUCCEEDED);
Review comment:
So we complete `shutDownFuture` here and cluster entrypoint takes care of
the close of the whole cluster?
Another concern is `ApplicationStatus.SUCCEEDED` v.s.
`ApplicationStatus.CANCEL` since, IIRC, shutDownCluster is called via REST so
it means user shutdown the cluster intendedly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
