pnowojski opened a new pull request #9826: [FLINK-10995][benchmarks] Use BroadcastRecordWriter for network broadcast benchmarks URL: https://github.com/apache/flink/pull/9826 After merging https://github.com/apache/flink/pull/7713 we haven't observed the performance improvement in the benchmarks, because broadcasting was not properly configured in the `networkBroadcastThroughput` benchmark. This PR fixes that. Local tests shows that the before mentioned PR when tested with this fix, improved the `networkBroadcastThroughput` throughput from `640 ops/ms` to `950 ops/ms`. ## Verifying this change This change is already covered by existing tests, such as `StreamNetworkThroughputBenchmarkTest` and `StreamNetworkBroadcastThroughputBenchmarkTest`. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
