tillrohrmann commented on a change in pull request #9810: [FLINK-14284] Add
shut down future to Dispatcher
URL: https://github.com/apache/flink/pull/9810#discussion_r329977825
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -603,7 +616,7 @@ private JobManagerRunner
startJobManagerRunner(JobManagerRunner jobManagerRunner
@Override
public CompletableFuture<Acknowledge> shutDownCluster() {
- closeAsync();
+ shutDownFuture.complete(ApplicationStatus.SUCCEEDED);
Review comment:
The reason why we complete the shut down future with `SUCCEEDED` is to
imitate the job cluster behaviour when submitting multi staged jobs (which
under the hood spawns a session cluster). It is not perfect but a workaround to
not confuse people when they see that the Yarn application has been canceled if
they submitted a job in per-job mode. I think it is ok for the moment and can
be changed to `CANCELED` once we have proper per-job mode support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
