AHeise commented on a change in pull request #9735: [FLINK-14156][runtime] 
Submit timer trigger letters to task's mailbox with operator's precedence
URL: https://github.com/apache/flink/pull/9735#discussion_r330475591
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SystemProcessingTimeService.java
 ##########
 @@ -250,37 +250,36 @@ int getNumTasksScheduled() {
        // 
------------------------------------------------------------------------
 
        /**
-        * A context to which {@link ProcessingTimeCallback} would be passed to 
be invoked when a timer is up.
+        * An exception handler, called when {@link ProcessingTimeCallback} 
throws an exception.
         */
-       interface ScheduledCallbackExecutionContext {
-
-               void invoke(ProcessingTimeCallback callback, long timestamp);
+       interface ExceptionHandler {
 
 Review comment:
   We already have some in 
`org.apache.flink.runtime.operators.sort.ExceptionHandler` . Can we unify them? 
Or can we use `AsyncExceptionHandler` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to