1u0 commented on a change in pull request #9735: [FLINK-14156][runtime] Submit
timer trigger letters to task's mailbox with operator's precedence
URL: https://github.com/apache/flink/pull/9735#discussion_r330549295
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SystemProcessingTimeService.java
##########
@@ -250,37 +250,36 @@ int getNumTasksScheduled() {
//
------------------------------------------------------------------------
/**
- * A context to which {@link ProcessingTimeCallback} would be passed to
be invoked when a timer is up.
+ * An exception handler, called when {@link ProcessingTimeCallback}
throws an exception.
*/
- interface ScheduledCallbackExecutionContext {
-
- void invoke(ProcessingTimeCallback callback, long timestamp);
+ interface ExceptionHandler {
Review comment:
I would not use `org.apache.flink.runtime.operators.sort.ExceptionHandler`
or `AsyncExceptionHandler` here, as they are both used in their own use case
(and were probably introduced on their own to have separation). Reusing them
here would be a false code reuse, imo.
I see a value to have a generic interface defined somewhere in
`org.apache.flink.util` (in `flink-core`?).
But even for the generic interface, the question is what should be the api
(currently, all three mentioned interfaces have some small different details).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
