tillrohrmann commented on issue #9501: [FLINK-12697] [State Backends] Support 
on-disk state storage for spill-able heap backend
URL: https://github.com/apache/flink/pull/9501#issuecomment-537509801
 
 
   > About the performance impact, lease refer to [the analysis of JDK CSLM 
implementation](https://docs.google.com/document/d/16VIY7o-18sM-pIlIYkbTuhKPmwfnqabCt_nlOARAzdg/edit#)
 and a compacted data structure we introduced for HBase to reduce GC pressure. 
Search for `Key space schema` and `Value space schema` in `SkipListUtils` and 
we could find a similar design here.
   
   Where exactly do I see the performance comparison?
   
   > About reusable object, it will add a lot of efforts/complexity making sure 
to prevent concurrent manipulation on it.
   
   Why would this be the case? The only accessing threads should be the Task's 
main thread and the asynchronous checkpointing, right? Couldn't we say that the 
asynchronous checkpointing creates one single instance and reuses this instance 
for the whole checkpointing procedure? One could make it even a thread local 
variable if one wants to have an easy solution. So I'm not sure where the 
argument comes from that using a thin wrapping object around a pointer will 
necessarily decrease performance.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to