GJL commented on a change in pull request #8760: [FLINK-12869] Add yarn acls
capability to flink containers
URL: https://github.com/apache/flink/pull/8760#discussion_r331463703
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
##########
@@ -263,6 +265,13 @@ private static LocalResource
registerLocalResource(FileSystem fs, Path remoteRsr
return localResource;
}
+ public static void setAclsFor(ContainerLaunchContext amContainer,
org.apache.flink.configuration.Configuration flinkConfig) {
+ amContainer.setApplicationACLs(new
HashMap<ApplicationAccessType, String>(){{
Review comment:
I would feel more comfortable if we only set
`ApplicationAccessType.VIEW_APP` and `ApplicationAccessType.MODIFY_APP`, if the
user actually configured application ACLs. Also, can we make the default values
of the new config options `null`? What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
