dianfu commented on a change in pull request #9748:
[FLINK-14016][python][flink-table-planner] Introduce DataStreamPythonCalc for
Python function execution
URL: https://github.com/apache/flink/pull/9748#discussion_r332346972
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/FunctionDefinition.java
##########
@@ -40,6 +40,13 @@
*/
FunctionKind getKind();
+ /**
+ * Returns the language of function this definition describes.
+ */
+ default FunctionLanguage getLanguage() {
Review comment:
`getLanguage` is used in places where it's needed to determine whether a UDF
is Python not not, e.g. in
[PythonScalarFunctionSplitRule](https://github.com/apache/flink/blob/2b608e3169ee416c922a8337c2ba5fa873516fde/flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/plan/rules/logical/PythonScalarFunctionSplitRule.scala#L149).
As the interface `PythonFunction` has provided enough information for that
purpose, so I'm +1 remove it. Have created ticket
https://issues.apache.org/jira/browse/FLINK-14342 to track it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
