TisonKun edited a comment on issue #9820: [FLINK-14290] Decouple plan 
translation from job execution/ClusterClient
URL: https://github.com/apache/flink/pull/9820#issuecomment-539386039
 
 
   Thanks for your ideas on FLINK-14263 and FLINK-14130 @aljoscha .
   
   For the issue about `FlinkPlan`, let's revisit the inheritance tree now. We 
have
   
   ```
   FlinkPlan
   - OptimizedPlan
   - StreamingPlan
      - StreamGraph
   ```
   
   Where `OptimizedPlan` is an instanced class while `StreamingPlan` is an 
interface, and the "unified interface" `FlinkPlan` is a tag interface.
   
   now with this pull request we have
   
   ```
   Pipeline
   - Plan
   - StreamGraph(inherited from StreamingPlan)
   ```
   
   and two versions of `PipelineTranslator`.
   
   Since `FlinkPlan` is actually a temporary class from batch `Plan` and 
streaming `StreamGraph` to `JobGraph` and we now have `PipelineTranslator`, I 
think we can both
   
   1. merge `StreamingPlan` into `StreamGraph` and let `Pipeline` be the 
unified interface.
   2. remove `FlinkPlan`, hide `OptimizedPlan` inside `PlanTranslator` and let 
it be a more internal concept.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to