liupc commented on a change in pull request #9703: [FLINK-14038]Add default GC
options for flink on yarn to facilitate debugging
URL: https://github.com/apache/flink/pull/9703#discussion_r332416065
##########
File path: flink-dist/src/main/flink-bin/bin/flink-daemon.sh
##########
@@ -85,6 +85,29 @@ id=$([ -f "$pid" ] && echo $(wc -l < "$pid") || echo "0")
FLINK_LOG_PREFIX="${FLINK_LOG_DIR}/flink-${FLINK_IDENT_STRING}-${DAEMON}-${id}-${HOSTNAME}"
log="${FLINK_LOG_PREFIX}.log"
out="${FLINK_LOG_PREFIX}.out"
+gclog="${FLINK_LOG_PREFIX}.gc_log"
Review comment:
I prefer to keep the name the same with log & out files, if we determine to
add PID in the gc_log filename, then we should also change the log&out file
names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
