ifndef-SleePy opened a new pull request #9853: [FLINK-13904][checkpointing] Avoid competition of checkpoint triggering URL: https://github.com/apache/flink/pull/9853 ## What is the purpose of the change * This is a part of reworking threading model of `CheckpointCoordinator` * This PR tries to avoid competition of checkpoint/savepoint triggering ## Brief change log * Make trigger thread of `CheckpointCoordinator` single-threaded * This is a preparation of running triggering in main thread executor * Get rid of trigger lock of `CheckpointCoordinator` * Manually schedule periodic checkpoint trigger instead of `scheduleAtFixedRate` * It simplifies the trigger logic * It reduces a lot of cancellations of periodic triggering * This is also a preparation of running triggering in main thread, because currently `scheduleAtFixedRate` is not supported yet in main thread executor * It also reworks some test case structures to satisfy code style checking ## Verifying this change * This change is already covered by existing tests * Actually in this PR, there is no new feature introduced. So we just need to make sure all existing tests could pass ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
