zentol opened a new pull request #9863: [FLINK-14008][release] Generate binary 
licensing during release
URL: https://github.com/apache/flink/pull/9863
 
 
   With this PR we generate the binary licensing during the release process, 
instead of having it generated under scm.
   
   This is significantly easier to maintain and provides more a more accurate 
licensing as it is now scala-version dependent.
   
   **IMPORTANT**: With this change the licensing is no longer copied as part of 
the flink-dist build process; hence any custom builds won't have any licensing 
attached. That said, in this case the licensing was likely wrong anyway.
   
   The first hotfix commit makes a small adjustment to `create_binary_release` 
to no longer use a wildcard for the flink version when changing directories. 
This simply isn't necessary since the version is well-defined and invites 
errors if _for some reason_ a directory is present with a different version.
   
   The second commit
   * `collect_license_files` to create the licensing files with the `-binary` 
suffix, as this is no longer necessary * modifies `create_binary_release` to 
call `collect_license_files` before taring the release
   
   The third commit removes the existing binary-licensing infrastructure, 
including
   * NOTICE-binary and licenses-binary as they are now subsumed
   * flink-dist assembly sections for copying binary-licensing files
   * travis check for validity of binary licensing

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to