zentol opened a new pull request #9867: [FLINK-7958][metrics] Reporters provide default delimiter URL: https://github.com/apache/flink/pull/9867 Currently, the delimiter used for assembling the metric identifier is either based on a delimiter configured for the reporter, or the globally configured delimiter (default: '.'). Additionally (just for context), there are some instances around logicalScopes where reporters themselves can decide on the delimiter. External systems usually have well-defined requirements on what the delimiter should be, and it thus seems reasonable to allow reporters to provide a default delimiter, instead of using a global default across all reporters. This PR adds a method for retrieving this delimiter from the reporter. This delimiter is used as the default, and can be overwritten by explicitly configuring a delimiter for this reporter. This means that the global delimiter is no longer used in the context of a reporter, which is a slight change in behavior that must be documented in the release notes. While useful on it's own this PR is primarily a preparatory step for properly exposing the logical scope; which currently is tricky to do since reporters using this currently inject a non-default delimiter that isn't controllable. Due to not being controllable the used methods should not be exposed publicly, but this in turn requires a different mechanism for reporters to define a delimiter.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
