wuchong commented on a change in pull request #9799: 
[FLINK-13360][documentation] Add documentation for HBase connector for Table 
API & SQL
URL: https://github.com/apache/flink/pull/9799#discussion_r333310277
 
 

 ##########
 File path: docs/dev/table/connect.md
 ##########
 @@ -1115,12 +1106,15 @@ connector:
     znode.parent: "/test"        # required: the root dir in Zookeeper for 
HBase cluster
     
   write.buffer-flush:
-    max-size: 1048576            # optional: Write option, sets when to flush 
a buffered request
-                                 # based on the memory size of rows currently 
added.
-    max-rows: 1                  # optional: Write option, sets when to flush 
buffered 
-                                 # request based on the number of rows 
currently added.
-    interval: 1                  # optional: Write option, sets a flush 
interval flushing buffered 
-                                 # requesting if the interval passes, in 
milliseconds.
+    max-size: 1048576            # optional: writing option, determines how 
many size in memory of buffered
+                                 # rows to insert per round trip. This can 
help performance on writing to JDBC
+                                 # database. The default value is "2mb".
+    max-rows: 1                  # optional: writing option, determines how 
many rows to insert per round trip.
+                                 #This can help performance on writing to JDBC 
database. No default value,
+                                 # i.e. the default flushing is not depends on 
the number of buffered rows.
+    interval: 1                  # optional: writing option, sets a flush 
interval flushing buffered requesting
 
 Review comment:
   Please also update the values in YAML. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to